providers/base: add fscrypt test (New) #2215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhost
force-pushed
the
fhost/fscrypt
branch
2 times, most recently
from
3334c41 to
bc7d5f2
Compare
fhost
changed the title
fhost
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2215 +/- ##
==========================================
+ Coverage 53.70% 53.83% +0.12%
==========================================
Files 401 402 +1
Lines 43144 43270 +126
Branches 7996 8023 +27
==========================================
+ Hits 23170 23293 +123
- Misses 19161 19162 +1
- Partials 813 815 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fhost
force-pushed
the
fhost/fscrypt
branch
5 times, most recently
from
c4de44f to
cef64d9
Compare
hawesy-can
reviewed
Dec 11, 2025
hawesy-can
reviewed
Dec 11, 2025
hawesy-can
left a comment
hawesy-can
left a comment
There was a problem hiding this comment.
LGTM, but I'm not an expert in this area.
hawesy-can
reviewed
Dec 11, 2025
fhost
force-pushed
the
fhost/fscrypt
branch
2 times, most recently
from
4aba6b4 to
9a34ccc
Compare
fhost
force-pushed
the
fhost/fscrypt
branch
2 times, most recently
from
3de25d3 to
4e57c8d
Compare
pieqq
requested changes
Jan 9, 2026
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Sorry for the long silence. I've added a few comments, see if they make sense.
fhost
force-pushed
the
fhost/fscrypt
branch
5 times, most recently
from
270f461 to
a585b2c
Compare
pieqq
requested changes
Jan 12, 2026
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
One last tiny change request, and then it should be good.
pieqq
approved these changes
Jan 12, 2026
Collaborator
pieqq
left a comment
pieqq
left a comment
There was a problem hiding this comment.
Thanks! Let's see if CI passes for older builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New: Add a small fscrypt test into the base provider, in its own category.
Description
The new fscrypt test generates an ext4 disk image, mount it and setup fscrypt.
Then it creates a file in the disk image mountpoint, locks it and verifies that the file is not accessible anymore. Finally, it unlocks it and check that the file is accessible and its content is correct.
Tests
checkbox-cli, selectautomated fscrypt test, run the test plan. Tested on my laptop and on my project device (qualcomm arm64 device). Testing with fscrypt already setup and not setup.